1
0
mirror of https://github.com/duke-git/lancet.git synced 2026-02-04 12:52:28 +08:00

Filter: remove second loop and indexes slice (#12)

Use less memory and cpu resources to filter out elements from the slice.
This commit is contained in:
donutloop
2022-01-03 13:10:15 +01:00
committed by GitHub
parent 4fd8a18677
commit bc39b0887b

View File

@@ -154,18 +154,14 @@ func Filter(slice, function interface{}) interface{} {
panic("function param should be of type func(int, " + elemType.String() + ")" + reflect.ValueOf(true).Type().String())
}
var indexes []int
res := reflect.MakeSlice(sv.Type(), 0, 0)
for i := 0; i < sv.Len(); i++ {
flag := fn.Call([]reflect.Value{reflect.ValueOf(i), sv.Index(i)})[0]
if flag.Bool() {
indexes = append(indexes, i)
res = reflect.Append(res, sv.Index(i))
}
}
res := reflect.MakeSlice(sv.Type(), len(indexes), len(indexes))
for i := range indexes {
res.Index(i).Set(sv.Index(indexes[i]))
}
return res.Interface()
}