refactor: code improvement, ToString, Contain, Compact

convertor/convertor.go

@@ -90,34 +90,50 @@ func ToChannel[T any](array []T) <-chan T {
 }
 
 // ToString convert value to string
+// for number, string, []byte, will convert to string
+// for other type (slice, map, array, struct) will call json.Marshal
 func ToString(value any) string {
-	result := ""
 	if value == nil {
-		return result
+		return ""
 	}
 
-	v := reflect.ValueOf(value)
-
 	switch value.(type) {
-	case float32, float64:
-		result = strconv.FormatFloat(v.Float(), 'f', -1, 64)
-		return result
-	case int, int8, int16, int32, int64:
-		result = strconv.FormatInt(v.Int(), 10)
-		return result
-	case uint, uint8, uint16, uint32, uint64:
-		result = strconv.FormatUint(v.Uint(), 10)
-		return result
+	case float32:
+		return strconv.FormatFloat(float64(value.(float32)), 'f', -1, 32)
+	case float64:
+		return strconv.FormatFloat(value.(float64), 'f', -1, 64)
+	case int:
+		return strconv.FormatInt(int64(value.(int)), 10)
+	case int8:
+		return strconv.FormatInt(int64(value.(int8)), 10)
+	case int16:
+		return strconv.FormatInt(int64(value.(int16)), 10)
+	case int32:
+		return strconv.FormatInt(int64(value.(int32)), 10)
+	case int64:
+		return strconv.FormatInt(value.(int64), 10)
+	case uint:
+		return strconv.FormatUint(uint64(value.(uint)), 10)
+	case uint8:
+		return strconv.FormatUint(uint64(value.(uint8)), 10)
+	case uint16:
+		return strconv.FormatUint(uint64(value.(uint16)), 10)
+	case uint32:
+		return strconv.FormatUint(uint64(value.(uint32)), 10)
+	case uint64:
+		return strconv.FormatUint(value.(uint64), 10)
 	case string:
-		result = v.String()
-		return result
+		return value.(string)
 	case []byte:
-		result = string(v.Bytes())
-		return result
+		return string(value.([]byte))
 	default:
 		newValue, _ := json.Marshal(value)
-		result = string(newValue)
-		return result
+		return string(newValue)
+
+		// todo: maybe we should't supprt other type convertion
+		// v := reflect.ValueOf(value)
+		// log.Panicf("Unsupported data type: %s ", v.String())
+		// return ""
 	}
 }
 

convertor/convertor_test.go

@@ -137,9 +137,10 @@ func TestToString(t *testing.T) {
 		"", "",
 		"0", "1", "-1",
 		"123", "123", "123", "123", "123", "123", "123",
-		"12.3", "12.300000190734863",
+		"12.3", "12.3",
 		"true", "false",
-		"[1,2,3]", "{\"a\":1,\"b\":2,\"c\":3}", "{\"Name\":\"TestStruct\"}", "hello"}
+		"[1,2,3]", "{\"a\":1,\"b\":2,\"c\":3}", "{\"Name\":\"TestStruct\"}", "hello",
+	}
 
 	for i := 0; i < len(cases); i++ {
 		actual := ToString(cases[i])

slice/slice.go

@@ -12,15 +12,15 @@ import (
 	"sort"
 )
 
-// Contain check if the value is in the slice or not
-func Contain[T comparable](slice []T, value T) bool {
-	set := make(map[T]struct{}, len(slice))
-	for _, v := range slice {
-		set[v] = struct{}{}
+// Contain check if the target value is in the slice or not
+func Contain[T comparable](slice []T, target T) bool {
+	for _, item := range slice {
+		if item == target {
+			return true
+		}
 	}
 
-	_, ok := set[value]
-	return ok
+	return false
 }
 
 // ContainSubSlice check if the slice contain subslice or not
@@ -57,14 +57,14 @@ func Chunk[T any](slice []T, size int) [][]T {
 }
 
 // Compact creates an slice with all falsey values removed. The values false, nil, 0, and "" are falsey
-func Compact[T any](slice []T) []T {
-	result := make([]T, 0)
-	for _, v := range slice {
-		if !reflect.DeepEqual(v, nil) &&
-			!reflect.DeepEqual(v, false) &&
-			!reflect.DeepEqual(v, "") &&
-			!reflect.DeepEqual(v, 0) {
-			result = append(result, v)
+func Compact[T comparable](slice []T) []T {
+	var zero T
+
+	result := []T{}
+
+	for _, item := range slice {
+		if item != zero {
+			result = append(result, item)
 		}
 	}