mirror of
https://github.com/duke-git/lancet.git
synced 2026-11-16 05:12:11 +08:00
fix(package): [tree] apply the replacement root on deletion (#407)
This commit is contained in:
1 parent
03695c886c
commit
9f7d939e5a
3 files changed
+70
-2
No files matched your search
@@ -40,7 +40,7 @@ func (t *BSTree[T]) Insert(data T) {
|
||||
|
||||
// DeletetNode delete data into BSTree
|
||||
func (t *BSTree[T]) Delete(data T) {
|
||||
deleteTreeNode(t.root, data, t.comparator)
|
||||
t.root = deleteTreeNode(t.root, data, t.comparator)
|
||||
}
|
||||
|
||||
// NodeLevel get node level in BSTree
|
||||
|
||||
@@ -0,0 +1,66 @@
|
||||
package datastructure
|
||||
|
||||
import (
|
||||
"sort"
|
||||
"strconv"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestBSTreeDeleteReplacesRoot(t *testing.T) {
|
||||
for i, tt := range []struct {
|
||||
values []int
|
||||
remove int
|
||||
want []int
|
||||
}{
|
||||
{nil, 4, nil},
|
||||
{[]int{2, 1, 3}, 4, []int{1, 2, 3}},
|
||||
{[]int{6, 5, 7}, 4, []int{5, 6, 7}},
|
||||
{[]int{2, 6, 1, 3, 5, 7}, 4, []int{1, 2, 3, 5, 6, 7}},
|
||||
{[]int{2, 6}, 9, []int{2, 4, 6}},
|
||||
{[]int{2, 6}, 2, []int{4, 6}},
|
||||
{[]int{2, 6, 1}, 2, []int{1, 4, 6}},
|
||||
{[]int{2, 6, 1, 3}, 2, []int{1, 3, 4, 6}},
|
||||
} {
|
||||
t.Run(strconv.Itoa(i), func(t *testing.T) {
|
||||
tree := NewBSTree(4, &intComparator{})
|
||||
for _, value := range tt.values {
|
||||
tree.Insert(value)
|
||||
}
|
||||
tree.Delete(tt.remove)
|
||||
checkBSTValues(t, tree, tt.want)
|
||||
tree.Delete(tt.remove)
|
||||
checkBSTValues(t, tree, tt.want)
|
||||
tree.Insert(8)
|
||||
want := append(append([]int(nil), tt.want...), 8)
|
||||
sort.Ints(want)
|
||||
checkBSTValues(t, tree, want)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func checkBSTValues(t *testing.T, tree *BSTree[int], want []int) {
|
||||
t.Helper()
|
||||
inOrder := tree.InOrderTraverse()
|
||||
if !sort.IntsAreSorted(inOrder) {
|
||||
t.Fatalf("in-order traversal is not sorted: %v", inOrder)
|
||||
}
|
||||
for name, got := range map[string][]int{
|
||||
"in-order": inOrder,
|
||||
"pre-order": tree.PreOrderTraverse(),
|
||||
"post-order": tree.PostOrderTraverse(),
|
||||
"level-order": tree.LevelOrderTraverse(),
|
||||
} {
|
||||
sort.Ints(got)
|
||||
if len(got) != len(want) {
|
||||
t.Fatalf("%s traversal = %v, want values %v", name, got, want)
|
||||
}
|
||||
for i := range want {
|
||||
if got[i] != want[i] {
|
||||
t.Fatalf("%s traversal = %v, want values %v", name, got, want)
|
||||
}
|
||||
}
|
||||
}
|
||||
if len(want) == 0 && tree.Depth() != 0 {
|
||||
t.Fatalf("empty tree depth = %d", tree.Depth())
|
||||
}
|
||||
}
|
||||
@@ -69,6 +69,9 @@ func inOrderTraverse[T any](node *datastructure.TreeNode[T]) []T {
|
||||
// }
|
||||
|
||||
func levelOrderTraverse[T any](root *datastructure.TreeNode[T], traversal *[]T) {
|
||||
if root == nil {
|
||||
return
|
||||
}
|
||||
var q []*datastructure.TreeNode[T] // queue
|
||||
var n *datastructure.TreeNode[T] // temp node
|
||||
|
||||
@@ -102,7 +105,6 @@ func insertTreeNode[T any](rootNode, newNode *datastructure.TreeNode[T], compara
|
||||
}
|
||||
}
|
||||
|
||||
// todo, delete root node failed
|
||||
func deleteTreeNode[T any](node *datastructure.TreeNode[T], data T, comparator constraints.Comparator) *datastructure.TreeNode[T] {
|
||||
if node == nil {
|
||||
return nil
|
||||
|
||||
Reference in new issue
Block a user