fix(convertor): clone array values without slice reflection (#380)

This commit is contained in:
Yusuf Efe authored and GitHub committed 2026-10-23 18:03:23 +08:00
1 parent 417cf68bd8
commit 86dc6c0019
2 files changed
+19 -2

No files matched your search

+7 -2
View File
@@ -51,11 +51,16 @@ func (c *cloner) clone(v reflect.Value) reflect.Value {
}
func (c *cloner) cloneArray(v reflect.Value) reflect.Value {
if v.IsNil() {
if v.Kind() == reflect.Slice && v.IsNil() {
return reflect.Zero(v.Type())
}
arr := reflect.MakeSlice(v.Type(), v.Len(), v.Len())
var arr reflect.Value
if v.Kind() == reflect.Array {
arr = reflect.New(v.Type()).Elem()
} else {
arr = reflect.MakeSlice(v.Type(), v.Len(), v.Len())
}
for i := 0; i < v.Len(); i++ {
val := c.clone(v.Index(i))
+12
View File
@@ -394,6 +394,18 @@ func TestDecodeByte(t *testing.T) {
assert.Equal("abc", obj)
}
func TestDeepCloneArrays(t *testing.T) {
assert := internal.NewAssert(t, "TestDeepCloneArrays")
value := 42
type pair [2]*int
src := pair{&value, nil}
got := DeepClone(src)
assert.Equal(src, got)
*got[0] = 99
assert.Equal(42, *src[0])
assert.Equal([0]int{}, DeepClone([0]int{}))
}
func TestDeepClone(t *testing.T) {
t.Parallel()