From 86dc6c0019a63ae48d6a26696e2b2af240c17c3b Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Fri, 23 Oct 2026 13:03:23 +0300 Subject: [PATCH] fix(convertor): clone array values without slice reflection (#380) --- convertor/convertor_internal.go | 9 +++++++-- convertor/convertor_test.go | 12 ++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/convertor/convertor_internal.go b/convertor/convertor_internal.go index 189e542..c1734c9 100644 --- a/convertor/convertor_internal.go +++ b/convertor/convertor_internal.go @@ -51,11 +51,16 @@ func (c *cloner) clone(v reflect.Value) reflect.Value { } func (c *cloner) cloneArray(v reflect.Value) reflect.Value { - if v.IsNil() { + if v.Kind() == reflect.Slice && v.IsNil() { return reflect.Zero(v.Type()) } - arr := reflect.MakeSlice(v.Type(), v.Len(), v.Len()) + var arr reflect.Value + if v.Kind() == reflect.Array { + arr = reflect.New(v.Type()).Elem() + } else { + arr = reflect.MakeSlice(v.Type(), v.Len(), v.Len()) + } for i := 0; i < v.Len(); i++ { val := c.clone(v.Index(i)) diff --git a/convertor/convertor_test.go b/convertor/convertor_test.go index 29a78fd..a5ced7a 100644 --- a/convertor/convertor_test.go +++ b/convertor/convertor_test.go @@ -394,6 +394,18 @@ func TestDecodeByte(t *testing.T) { assert.Equal("abc", obj) } +func TestDeepCloneArrays(t *testing.T) { + assert := internal.NewAssert(t, "TestDeepCloneArrays") + value := 42 + type pair [2]*int + src := pair{&value, nil} + got := DeepClone(src) + assert.Equal(src, got) + *got[0] = 99 + assert.Equal(42, *src[0]) + assert.Equal([0]int{}, DeepClone([0]int{})) +} + func TestDeepClone(t *testing.T) { t.Parallel()