update: update comment for ReadFileByLine in file.go

.github/workflows/codecov.yml

@@ -0,0 +1,22 @@
+name: Test and coverage
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 2
+      - uses: actions/setup-go@v2
+        with:
+          go-version: "1.16"
+      - name: Run coverage
+        run: go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic
+      - name: Upload coverage to Codecov
+        run: bash <(curl -s https://codecov.io/bash)

.gitignore

@@ -1,3 +1,6 @@
 .idea/*
 .vscode/*
-.DS_Store
+.DS_Store
+cryptor/*.txt
+fileutil/*.txt
+cryptor/*.pem

README.md

@@ -5,6 +5,13 @@
     </p>
 <div align="center" style="text-align: center;">
 
+![Go version](https://img.shields.io/badge/go-%3E%3D1.16<recommend>-9cf)
+[![Release](https://img.shields.io/badge/release-1.0.6-green.svg)](https://github.com/duke-git/lancet/releases)
+[![GoDoc](https://godoc.org/github.com//duke-git/lancet?status.svg)](https://pkg.go.dev/github.com/duke-git/lancet)
+[![Go Report Card](https://goreportcard.com/badge/github.com/duke-git/lancet)](https://goreportcard.com/report/github.com/duke-git/lancet)
+[![codecov](https://codecov.io/gh/duke-git/lancet/branch/main/graph/badge.svg?token=FC48T1F078)](https://codecov.io/gh/duke-git/lancet)
+[![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/duke-git/lancet/blob/main/LICENSE)
+
 </div>
 
 English | [简体中文](./README_zh-CN.md)
@@ -200,15 +207,18 @@ func main() {
 }
 ```
 
-- 函数列表：
+- Function list：
 
 ```go
+func ClearFile(path string) error //write empty string to path file
 func CreateFile(path string) bool // create a file in path
 func CopyFile(srcFilePath string, dstFilePath string) error //copy src file to dst file
 func IsExist(path string) bool  //checks if a file or directory exists
 func IsDir(path string) bool //checks if the path is directy or not
 func ListFileNames(path string) ([]string, error) //return all file names in the path
 func RemoveFile(path string) error //remove the path file
+func ReadFileToString(path string) (string, error) //return string of file content
+func ReadFileByLine(path string)([]string, error) //read file content by line
 ```
 
 #### 5. formatter is for data format
@@ -343,7 +353,9 @@ func Chunk(slice []interface{}, size int) [][]interface{} //creates an slice of
 func ConvertSlice(originalSlice interface{}, newSliceType reflect.Type) interface{} //convert originalSlice to newSliceType
 func Difference(slice1, slice2 interface{}) interface{} //creates an slice of whose element not included in the other given slice
 func DeleteByIndex(slice interface{}, start int, end ...int) (interface{}, error) //delete the element of slice from start index to end index - 1
+func Every(slice, function interface{}) bool //return true if all of the values in the slice pass the predicate function, function signature should be func(index int, value interface{}) bool
 func Filter(slice, function interface{}) interface{} //filter slice, function signature should be func(index int, value interface{}) bool
+func Find(slice, function interface{}) interface{} //iterates over elements of slice, returning the first one that passes a truth test on function.function signature should be func(index int, value interface{}) bool .
 func IntSlice(slice interface{}) ([]int, error) //convert value to int slice
 func InterfaceSlice(slice interface{}) []interface{} //convert value to interface{} slice
 func InsertByIndex(slice interface{}, index int, value interface{}) (interface{}, error) //insert the element into slice at index.
@@ -351,6 +363,7 @@ func Map(slice, function interface{}) interface{} //map lisce, function signatur
 func ReverseSlice(slice interface{}) //revere slice
 func Reduce(slice, function, zero interface{}) interface{} //reduce slice, function signature should be func(index int, value1, value2 interface{}) interface{}
 func SortByField(slice interface{}, field string, sortType ...string) error //sort struct slice by field
+func Some(slice, function interface{}) bool //return true if any of the values in the list pass the predicate function, function signature should be func(index int, value interface{}) bool
 func StringSlice(slice interface{}) []string //convert value to string slice
 func Unique(slice interface{}) interface{} //remove duplicate elements in slice
 func UpdateByIndex(slice interface{}, index int, value interface{}) (interface{}, error) //update the slice element at index.

README_zh-CN.md

@@ -5,6 +5,12 @@
     </p>
 <div align="center" style="text-align: center;">
 
+![Go version](https://img.shields.io/badge/go-%3E%3D1.16<recommend>-9cf)
+[![Release](https://img.shields.io/badge/release-1.0.6-green.svg)](https://github.com/duke-git/lancet/releases)
+[![GoDoc](https://godoc.org/github.com//duke-git/lancet?status.svg)](https://pkg.go.dev/github.com/duke-git/lancet)
+[![Go Report Card](https://goreportcard.com/badge/github.com/duke-git/lancet)](https://goreportcard.com/report/github.com/duke-git/lancet)
+[![codecov](https://codecov.io/gh/duke-git/lancet/branch/main/graph/badge.svg?token=FC48T1F078)](https://codecov.io/gh/duke-git/lancet)
+[![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/duke-git/lancet/blob/main/LICENSE)
 
 </div>
 
@@ -17,7 +23,7 @@
 - 👏 全面、高效、可复用
 - 💪 100+常用go工具函数，支持string、slice、datetime、net、crypt...
 - 💅 只依赖go标准库
-- 🌍 所有导出函数单测试覆盖率100%
+- 🌍 所有导出函数单元测试覆盖率100%
 
 ### 安装
 
@@ -57,7 +63,7 @@ func main() {
 #### 1. convertor数据转换包
 
 - 转换函数支持常用数据类型之间的转换
-- 导入包：import "github.com/duke-git/lancet/cryptor"
+- 导入包：import "github.com/duke-git/lancet/convertor"
 
 ```go
 package main
@@ -94,7 +100,7 @@ func StructToMap(value interface{}) (map[string]interface{}, error) //struct串
 
 #### 2. cryptor加解密包
 
-- 加密函数是支持md5, hmac, aes, des, ras
+- 加密函数支持md5, hmac, aes, des, ras
 - 导入包：import "github.com/duke-git/lancet/cryptor"
 
 ```go
@@ -205,12 +211,15 @@ func main() {
 - 函数列表：
 
 ```go
+func ClearFile(path string) error //清空文件内容
 func IsExist(path string) bool  //判断文件/目录是否存在
 func CreateFile(path string) bool //创建文件
 func IsDir(path string) bool //判断是否为目录
 func RemoveFile(path string) error //删除文件
 func CopyFile(srcFilePath string, dstFilePath string) error //复制文件
 func ListFileNames(path string) ([]string, error) //列出目录下所有文件名称
+func ReadFileToString(path string) (string, error) //读取文件内容为字符串
+func ReadFileByLine(path string)([]string, error) //按行读取文件内容
 ```
 
 #### 5. formatter格式化处理包
@@ -345,6 +354,8 @@ func Chunk(slice []interface{}, size int) [][]interface{} //均分slice
 func ConvertSlice(originalSlice interface{}, newSliceType reflect.Type) interface{} //将originalSlice转换为 newSliceType
 func Difference(slice1, slice2 interface{}) interface{} //返回
 func DeleteByIndex(slice interface{}, start int, end ...int) (interface{}, error) //删除切片中start到end位置的值
+func Every(slice, function interface{}) bool //slice中所有元素都符合函数条件时返回true, 否则返回false. 函数签名：func(index int, value interface{}) bool
+func Find(slice, function interface{}) interface{} //查找slice中第一个符合条件的元素，函数签名：func(index int, value interface{}) bool
 func Filter(slice, function interface{}) interface{} //过滤slice, 函数签名：func(index int, value interface{}) bool
 func IntSlice(slice interface{}) ([]int, error) //转成int切片
 func InterfaceSlice(slice interface{}) []interface{} //转成interface{}切片
@@ -352,6 +363,7 @@ func InsertByIndex(slice interface{}, index int, value interface{}) (interface{}
 func Map(slice, function interface{}) interface{} //遍历切片, 函数签名：func(index int, value interface{}) interface{}
 func ReverseSlice(slice interface{}) //反转切片
 func Reduce(slice, function, zero interface{}) interface{} //切片reduce操作， 函数签名：func(index int, value1, value2 interface{}) interface{}
+func Some(slice, function interface{}) bool //slice中任意一个元素都符合函数条件时返回true, 否则返回false. 函数签名：func(index int, value interface{}) bool
 func SortByField(slice interface{}, field string, sortType ...string) error //对struct切片进行排序
 func StringSlice(slice interface{}) []string //转为string切片
 func Unique(slice interface{}) interface{} //去重切片

convertor/convertor_test.go

@@ -2,9 +2,10 @@ package convertor
 
 import (
 	"fmt"
-	"github.com/duke-git/lancet/utils"
 	"reflect"
 	"testing"
+
+	"github.com/duke-git/lancet/utils"
 )
 
 func TestToChar(t *testing.T) {
@@ -58,8 +59,12 @@ func TestToBytes(t *testing.T) {
 }
 
 func TestToInt(t *testing.T) {
-	cases := []interface{}{"123", "-123", 123, "abc", false, "111111111111111111111111111111111111111"}
+	cases := []interface{}{"123", "-123", 123,
-	expected := []int64{123, -123, 123, 0, 0, 0}
+		uint(123), uint8(123), uint16(123), uint32(123), uint64(123),
+		float32(12.3), float64(12.3),
+		"abc", false, "111111111111111111111111111111111111111"}
+
+	expected := []int64{123, -123, 123, 123, 123, 123, 123, 123, 12, 12, 0, 0, 0}
 
 	for i := 0; i < len(cases); i++ {
 		res, _ := ToInt(cases[i])
@@ -71,8 +76,14 @@ func TestToInt(t *testing.T) {
 }
 
 func TestToFloat(t *testing.T) {
-	cases := []interface{}{"", "-1", "-.11", "1.23e3", ".123e10", "abc"}
+	cases := []interface{}{
-	expected := []float64{0, -1, -0.11, 1230, 0.123e10, 0}
+		"", "-1", "-.11", "1.23e3", ".123e10", "abc",
+		int(0), int8(1), int16(-1), int32(123), int64(123),
+		uint(123), uint8(123), uint16(123), uint32(123), uint64(123),
+		float64(12.3), float32(12.3),
+	}
+	expected := []float64{0, -1, -0.11, 1230, 0.123e10, 0,
+		0, 1, -1, 123, 123, 123, 123, 123, 123, 123, 12.3, 12.300000190734863}
 
 	for i := 0; i < len(cases); i++ {
 		res, _ := ToFloat(cases[i])
@@ -84,41 +95,37 @@ func TestToFloat(t *testing.T) {
 }
 
 func TestToString(t *testing.T) {
-	// basic type
-	toString(t, "a1", "a1")
-	toString(t, 111, "111")
-	toString(t, 111.01, "111.01")
-	toString(t, true, "true")
-	//toString(t, 1.5+10i, "(1.5+10i)")
-
-	// slice
-	aSlice := []int{1, 2, 3}
-	toString(t, aSlice, "[1,2,3]")
-
 	// map
 	aMap := make(map[string]int)
 	aMap["a"] = 1
 	aMap["b"] = 2
 	aMap["c"] = 3
 
-	toString(t, aMap, "{\"a\":1,\"b\":2,\"c\":3}")
-
 	// struct
 	type TestStruct struct {
 		Name string
 	}
 	aStruct := TestStruct{Name: "TestStruct"}
-	toString(t, aStruct, "{\"Name\":\"TestStruct\"}")
-}
 
-func toString(t *testing.T, test interface{}, expected string) {
+	cases := []interface{}{
-	res := ToString(test)
+		int(0), int8(1), int16(-1), int32(123), int64(123),
-	if res != expected {
+		uint(123), uint8(123), uint16(123), uint32(123), uint64(123),
-		utils.LogFailedTestInfo(t, "ToString", test, expected, res)
+		float64(12.3), float32(12.3),
-		t.FailNow()
+		true, false,
+		[]int{1, 2, 3}, aMap, aStruct, []byte{104, 101, 108, 108, 111}}
+
+	expected := []string{"0", "1", "-1", "123", "123", "123", "123", "123",
+		"123", "123", "12.3", "12.300000190734863", "true", "false",
+		"[1,2,3]", "{\"a\":1,\"b\":2,\"c\":3}", "{\"Name\":\"TestStruct\"}", "hello"}
+
+	for i := 0; i < len(cases); i++ {
+		res := ToString(cases[i])
+		if res != expected[i] {
+			utils.LogFailedTestInfo(t, "ToString", cases[i], expected[i], res)
+			t.FailNow()
+		}
 	}
 }
-
 func TestToJson(t *testing.T) {
 	// map
 	aMap := make(map[string]int)

fileutil/file.go

@@ -5,6 +5,7 @@
 package fileutil
 
 import (
+	"bufio"
 	"errors"
 	"io"
 	"io/ioutil"
@@ -17,7 +18,7 @@ func IsExist(path string) bool {
 	if err == nil {
 		return true
 	}
-	if errors.Is(err, os.ErrExist) {
+	if errors.Is(err, os.ErrNotExist) {
 		return false
 	}
 	return false
@@ -75,6 +76,53 @@ func CopyFile(srcFilePath string, dstFilePath string) error {
 	}
 }
 
+//ClearFile write empty string to path file
+func ClearFile(path string) error {
+	f, err := os.OpenFile(path, os.O_WRONLY|os.O_TRUNC, 0777)
+	if err != nil {
+		return err
+	}
+	defer f.Close()
+
+	_, err = f.WriteString("")
+	return err
+}
+
+//ReadFileToString return string of file content
+func ReadFileToString(path string) (string, error) {
+	bytes, err := ioutil.ReadFile(path)
+	if err != nil {
+		return "", err
+	}
+	return string(bytes), nil
+}
+
+// ReadFileByLine read file line by line
+func ReadFileByLine(path string) ([]string, error) {
+	f, err := os.Open(path)
+	if err != nil {
+		return nil, err
+	}
+	defer f.Close()
+
+	res := make([]string, 0)
+	buf := bufio.NewReader(f)
+
+	for {
+		line, _, err := buf.ReadLine()
+		l := string(line)
+		if err == io.EOF {
+			break
+		}
+		if err != nil {
+			continue
+		}
+		res = append(res, l)
+	}
+
+	return res, nil
+}
+
 // ListFileNames return all file names in the path
 func ListFileNames(path string) ([]string, error) {
 	if !IsExist(path) {

fileutil/file_test.go

@@ -9,8 +9,8 @@ import (
 )
 
 func TestIsExist(t *testing.T) {
-	cases := []string{"./", "./a.txt"}
+	cases := []string{"./", "./file.go", "./a.txt"}
-	expected := []bool{true, false}
+	expected := []bool{true, true, false}
 
 	for i := 0; i < len(cases); i++ {
 		res := IsExist(cases[i])
@@ -87,14 +87,52 @@ func TestCopyFile(t *testing.T) {
 }
 
 func TestListFileNames(t *testing.T) {
-	filesInCurrentPath, err := ListFileNames("./")
+	filesInCurrentPath, err := ListFileNames("../datetime/")
 	if err != nil {
 		t.FailNow()
 	}
-	expected := []string{"file.go", "file_test.go"}
+	expected := []string{"datetime.go", "datetime_test.go"}
 	if !reflect.DeepEqual(filesInCurrentPath, expected) {
 		utils.LogFailedTestInfo(t, "ToChar", "./", expected, filesInCurrentPath)
 		t.FailNow()
 	}
-
 }
+
+func TestReadFileToString(t *testing.T) {
+	path := "./text.txt"
+	CreateFile(path)
+	f, _ := os.OpenFile(path, os.O_WRONLY|os.O_TRUNC, 0777)
+	f.WriteString("hello world")
+
+	res, _ := ReadFileToString(path)
+	if res != "hello world" {
+		utils.LogFailedTestInfo(t, "ReadFileToString", path, "hello world", res)
+	}
+}
+
+func TestClearFile(t *testing.T) {
+	path := "./text.txt"
+	CreateFile(path)
+	f, _ := os.OpenFile(path, os.O_WRONLY|os.O_TRUNC, 0777)
+	f.WriteString("hello world")
+
+	CreateFile(path)
+
+	res, _ := ReadFileToString(path)
+	if res != "" {
+		utils.LogFailedTestInfo(t, "CreateFile", path, "", res)
+	}
+}
+
+func TestReadFileByLine(t *testing.T) {
+	path := "./text.txt"
+	CreateFile(path)
+	f, _ := os.OpenFile(path, os.O_WRONLY|os.O_TRUNC, 0777)
+	f.WriteString("hello\nworld")
+
+	expected := []string{"hello", "world"}
+	res, _ := ReadFileByLine(path)
+	if !reflect.DeepEqual(res, expected) {
+		utils.LogFailedTestInfo(t, "ReadFileByLine", path, expected, res)
+	}
+}

formatter/formatter_test.go

@@ -9,6 +9,8 @@ import (
 func TestComma(t *testing.T) {
 	comma(t, "", "", "")
 	comma(t, "aa", "", "")
+	comma(t, "aa.a", "", "")
+	comma(t, []int{1}, "", "")
 	comma(t, "123", "", "123")
 	comma(t, "12345", "", "12,345")
 	comma(t, 12345, "", "12,345")

netutil/request_test.go

@@ -11,6 +11,11 @@ import (
 )
 
 func TestHttpGet(t *testing.T) {
+	_, e := HttpGet("", nil)
+	if e == nil {
+		t.FailNow()
+	}
+
 	url := "https://gutendex.com/books?"
 	queryParams := make(map[string]interface{})
 	queryParams["ids"] = "1"

netutil/request_util.go

@@ -124,7 +124,7 @@ func setQueryParam(req *http.Request, reqUrl string, queryParam interface{}) err
 		case map[string]interface{}:
 			values = url.Values{}
 			for k := range v {
-				values.Set(k, fmt.Sprintf("%s", v[k]))
+				values.Set(k, fmt.Sprintf("%v", v[k]))
 			}
 		case url.Values:
 			values = v

random/random_test.go

@@ -1,11 +1,20 @@
+/*
+ * @Descripttion:
+ * @version: v1.0.0
+ * @Author: dudaodong@kingsoft.com
+ * @Date: 2021-11-29 11:43:28
+ * @LastEditors: dudaodong@kingsoft.com
+ * @LastEditTime: 2021-12-01 18:05:29
+ */
 package random
 
 import (
 	"fmt"
-	"github.com/duke-git/lancet/utils"
 	"reflect"
 	"regexp"
 	"testing"
+
+	"github.com/duke-git/lancet/utils"
 )
 
 func TestRandString(t *testing.T) {
@@ -21,26 +30,42 @@ func TestRandString(t *testing.T) {
 }
 
 func TestRandInt(t *testing.T) {
-	randInt := RandInt(1, 10)
+	res1 := RandInt(1, 10)
+	if res1 < 1 || res1 >= 10 {
+		utils.LogFailedTestInfo(t, "RandInt", "RandInt(1, 10)", "RandInt(1, 10) should between [1, 10) ", res1)
+		t.FailNow()
+	}
 
-	if randInt < 1 || randInt >= 10 {
+	res2 := RandInt(1, 1)
-		utils.LogFailedTestInfo(t, "RandInt", "RandInt(1, 10)", "RandInt(1, 10) should between [1, 10) ", randInt)
+	if res2 != 1 {
+		utils.LogFailedTestInfo(t, "RandInt", "RandInt(1, 1)", "RandInt(1, 1) should be 1 ", res2)
+		t.FailNow()
+	}
+
+	res3 := RandInt(10, 1)
+	if res3 < 1 || res3 >= 10 {
+		utils.LogFailedTestInfo(t, "RandInt", "RandInt(10, 1)", "RandInt(10, 1) should between [1, 10) ", res3)
 		t.FailNow()
 	}
 }
 
 func TestRandBytes(t *testing.T) {
 	randBytes := RandBytes(4)
-
 	if len(randBytes) != 4 {
 		utils.LogFailedTestInfo(t, "RandBytes", "RandBytes(4)", "RandBytes(4) should return 4 element of []bytes", randBytes)
 		t.FailNow()
 	}
-
 	v := reflect.ValueOf(randBytes)
 	et := v.Type().Elem()
 	if v.Kind() != reflect.Slice || et.Kind() != reflect.Uint8 {
 		utils.LogFailedTestInfo(t, "RandBytes", "RandBytes(4)", "RandBytes(4) should return 4 element of []bytes", randBytes)
 		t.FailNow()
 	}
+
+	randErr := RandBytes(0)
+	if randErr != nil {
+		utils.LogFailedTestInfo(t, "RandBytes", "RandBytes(0)", "RandBytes(0) should return nil", randErr)
+		t.FailNow()
+	}
+
 }

slice/slice.go

@@ -89,6 +89,50 @@ func Difference(slice1, slice2 interface{}) interface{} {
 	return res.Interface()
 }
 
+// Every return true if all of the values in the slice pass the predicate function.
+// The function signature should be func(index int, value interface{}) bool .
+func Every(slice, function interface{}) bool {
+	sv := sliceValue(slice)
+	fn := functionValue(function)
+
+	elemType := sv.Type().Elem()
+	if checkSliceCallbackFuncSignature(fn, elemType, reflect.ValueOf(true).Type()) {
+		panic("Filter function must be of type func(int, " + elemType.String() + ")" + reflect.ValueOf(true).Type().String())
+	}
+
+	var indexes []int
+	for i := 0; i < sv.Len(); i++ {
+		flag := fn.Call([]reflect.Value{reflect.ValueOf(i), sv.Index(i)})[0]
+		if flag.Bool() {
+			indexes = append(indexes, i)
+		}
+	}
+
+	return len(indexes) == sv.Len()
+}
+
+// Some return true if any of the values in the list pass the predicate function.
+// The function signature should be func(index int, value interface{}) bool .
+func Some(slice, function interface{}) bool {
+	sv := sliceValue(slice)
+	fn := functionValue(function)
+
+	elemType := sv.Type().Elem()
+	if checkSliceCallbackFuncSignature(fn, elemType, reflect.ValueOf(true).Type()) {
+		panic("Filter function must be of type func(int, " + elemType.String() + ")" + reflect.ValueOf(true).Type().String())
+	}
+
+	var indexes []int
+	for i := 0; i < sv.Len(); i++ {
+		flag := fn.Call([]reflect.Value{reflect.ValueOf(i), sv.Index(i)})[0]
+		if flag.Bool() {
+			indexes = append(indexes, i)
+		}
+	}
+
+	return len(indexes) > 0
+}
+
 // Filter iterates over elements of slice, returning an slice of all elements `signature` returns truthy for.
 // The function signature should be func(index int, value interface{}) bool .
 func Filter(slice, function interface{}) interface{} {
@@ -115,6 +159,28 @@ func Filter(slice, function interface{}) interface{} {
 	return res.Interface()
 }
 
+// Find iterates over elements of slice, returning the first one that passes a truth test on function.
+// The function signature should be func(index int, value interface{}) bool .
+func Find(slice, function interface{}) interface{} {
+	sv := sliceValue(slice)
+	fn := functionValue(function)
+
+	elemType := sv.Type().Elem()
+	if checkSliceCallbackFuncSignature(fn, elemType, reflect.ValueOf(true).Type()) {
+		panic("Filter function must be of type func(int, " + elemType.String() + ")" + reflect.ValueOf(true).Type().String())
+	}
+
+	var index int
+	for i := 0; i < sv.Len(); i++ {
+		flag := fn.Call([]reflect.Value{reflect.ValueOf(i), sv.Index(i)})[0]
+		if flag.Bool() {
+			index = i
+			break
+		}
+	}
+	return sv.Index(index).Interface()
+}
+
 // Map creates an slice of values by running each element of `slice` thru `function`.
 // The function signature should be func(index int, value interface{}) interface{}.
 func Map(slice, function interface{}) interface{} {
@@ -137,17 +203,16 @@ func Map(slice, function interface{}) interface{} {
 // The function signature should be func(index int, value1, value2 interface{}) interface{} .
 func Reduce(slice, function, zero interface{}) interface{} {
 	sv := sliceValue(slice)
+	elementType := sv.Type().Elem()
 
 	len := sv.Len()
 	if len == 0 {
 		return zero
 	} else if len == 1 {
-		return sv.Index(0)
+		return sv.Index(0).Interface()
 	}
 
-	elementType := sv.Type().Elem()
 	fn := functionValue(function)
-
 	if checkSliceCallbackFuncSignature(fn, elementType, elementType, elementType) {
 		t := elementType.String()
 		panic("Reduce function must be of type func(int, " + t + ", " + t + ")" + t)

slice/slice_test.go

@@ -14,6 +14,15 @@ func TestContain(t *testing.T) {
 
 	var t2 []string
 	contain(t, t2, "1", false)
+
+	m := make(map[string]int)
+	m["a"] = 1
+	contain(t, m, "a", true)
+	contain(t, m, "b", false)
+
+	s := "hello"
+	contain(t, s, "h", true)
+	contain(t, s, "s", false)
 }
 
 func contain(t *testing.T, test interface{}, value interface{}, expected bool) {
@@ -87,15 +96,39 @@ func TestConvertSlice(t *testing.T) {
 	//}
 }
 
+func TestEvery(t *testing.T) {
+	nums := []int{1, 2, 3, 5}
+	isEven := func(i, num int) bool {
+		return num%2 == 0
+	}
+	res := Every(nums, isEven)
+	if res != false {
+		utils.LogFailedTestInfo(t, "Every", nums, false, res)
+		t.FailNow()
+	}
+}
+
+func TestSome(t *testing.T) {
+	nums := []int{1, 2, 3, 5}
+	isEven := func(i, num int) bool {
+		return num%2 == 0
+	}
+	res := Some(nums, isEven)
+	if res != true {
+		utils.LogFailedTestInfo(t, "Some", nums, true, res)
+		t.FailNow()
+	}
+}
+
 func TestFilter(t *testing.T) {
-	s1 := []int{1, 2, 3, 4, 5}
+	nums := []int{1, 2, 3, 4, 5}
 	even := func(i, num int) bool {
 		return num%2 == 0
 	}
 	e1 := []int{2, 4}
-	r1 := Filter(s1, even)
+	r1 := Filter(nums, even)
 	if !reflect.DeepEqual(r1, e1) {
-		utils.LogFailedTestInfo(t, "Filter", s1, e1, r1)
+		utils.LogFailedTestInfo(t, "Filter", nums, e1, r1)
 		t.FailNow()
 	}
 
@@ -128,6 +161,18 @@ func TestFilter(t *testing.T) {
 
 }
 
+func TestFind(t *testing.T) {
+	nums := []int{1, 2, 3, 4, 5}
+	even := func(i, num int) bool {
+		return num%2 == 0
+	}
+	res := Find(nums, even)
+	if res != 2 {
+		utils.LogFailedTestInfo(t, "Find", nums, 2, res)
+		t.FailNow()
+	}
+}
+
 func TestMap(t *testing.T) {
 	s1 := []int{1, 2, 3, 4}
 	multiplyTwo := func(i, num int) int {
@@ -167,28 +212,21 @@ func TestMap(t *testing.T) {
 }
 
 func TestReduce(t *testing.T) {
-	s1 := []int{1, 2, 3, 4}
+	cases := [][]int{
-	f1 := func(i, v1, v2 int) int {
+		{},
+		{1},
+		{1, 2, 3, 4}}
+	expected := []int{0, 1, 10}
+	f := func(i, v1, v2 int) int {
 		return v1 + v2
 	}
-	e1 := 10
+	for i := 0; i < len(cases); i++ {
-	r1 := Reduce(s1, f1, 0)
+		res := Reduce(cases[i], f, 0)
-	if e1 != r1 {
+		if res != expected[i] {
-		utils.LogFailedTestInfo(t, "Reduce", s1, e1, r1)
+			utils.LogFailedTestInfo(t, "Reduce", cases[i], expected[i], res)
-		t.FailNow()
+			t.FailNow()
+		}
 	}
-
-	// failed Reduce function should be func(i int, v1, v2 int) int
-	//s1 := []int{1, 2, 3, 4}
-	//f1 := func(i string, v1, v2 int) int { //i should be int
-	//	return v1+v2
-	//}
-	//e1 := 10
-	//r1 := Reduce(s1, f1, 0)
-	//if e1 != r1 {
-	//	utils.LogFailedTestInfo(t, "Reduce", s1, e1, r1)
-	//	t.FailNow()
-	//}
 }
 
 func TestIntSlice(t *testing.T) {
@@ -340,11 +378,6 @@ func TestUpdateByIndex(t *testing.T) {
 	r3 := []string{"a", "b", "1"}
 	updateByIndex(t, t1, 2, "1", r3)
 
-	//failed
-	//t1 = []string{"a","b","c"}
-	//r4 := []string{"a", "b", "1"}
-	//updateByIndex(t, t1, 3, "1", r4)
-
 }
 
 func updateByIndex(t *testing.T, test interface{}, index int, value, expected interface{}) {

validator/validator.go

@@ -26,11 +26,7 @@ func IsNumberStr(s string) bool {
 // IsFloatStr check if the string can convert to a float.
 func IsFloatStr(s string) bool {
 	_, e := strconv.ParseFloat(s, 64)
-
+	return e == nil
-	if e != nil {
-		return false
-	}
-	return true
 }
 
 // IsIntStr check if the string can convert to a integer.
@@ -42,10 +38,7 @@ func IsIntStr(s string) bool {
 // IsIp check if the string is a ip address.
 func IsIp(ipstr string) bool {
 	ip := net.ParseIP(ipstr)
-	if ip == nil {
+	return ip != nil
-		return false
-	}
-	return true
 }
 
 // IsIpV4 check if the string is a ipv4 address.

validator/validator_test.go

@@ -190,7 +190,7 @@ func isCreditCard(t *testing.T, source string, expected bool) {
 }
 
 func TestIsBase64(t *testing.T) {
-	isBase64(t, "aGVsbG8", true)
+	isBase64(t, "aGVsbG8=", true)
 	isBase64(t, "123456", false)
 }