From febd1030afa6d322794cc12a9513ce23c82471e4 Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Thu, 22 Oct 2026 05:47:25 +0300 Subject: [PATCH] fix(package): [list] preserve source storage during merge (#391) --- datastructure/list/list.go | 4 ++-- datastructure/list/merge_storage_test.go | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 datastructure/list/merge_storage_test.go diff --git a/datastructure/list/list.go b/datastructure/list/list.go index 78813f7..e91f4b3 100644 --- a/datastructure/list/list.go +++ b/datastructure/list/list.go @@ -239,8 +239,8 @@ func (l *List[T]) Merge(other *List[T]) *List[T] { l1, l2 := len(l.data), len(other.data) ml := NewList(make([]T, l1+l2)) - data := append([]T{}, append(l.data, other.data...)...) - ml.data = data + copy(ml.data, l.data) + copy(ml.data[l1:], other.data) return ml } diff --git a/datastructure/list/merge_storage_test.go b/datastructure/list/merge_storage_test.go new file mode 100644 index 0000000..b81ac05 --- /dev/null +++ b/datastructure/list/merge_storage_test.go @@ -0,0 +1,18 @@ +package datastructure + +import ( + "testing" + + "github.com/duke-git/lancet/v2/internal" +) + +func TestMergePreservesBackingStorage(t *testing.T) { + assert := internal.NewAssert(t, "TestMergePreservesBackingStorage") + backing := []int{1, 99, 100} + left := NewList(backing[:1]) + merged := left.Merge(NewList([]int{2, 3})) + assert.Equal([]int{1, 2, 3}, merged.Data()) + assert.Equal([]int{1, 99, 100}, backing) + merged.UpdateAt(0, 42) + assert.Equal([]int{1}, left.Data()) +}