fix(package): [tree] recurse in postorder traversal (#411)

This commit is contained in:
Rupayon Haldar authored and GitHub committed 2026-11-02 10:43:54 +08:00
1 parent 8dd57ef490
commit e393f0e14f
3 files changed
+53 -3

No files matched your search

+1 -1
View File
@@ -49,7 +49,7 @@ func TestBSTree_PostOrderTraverse(t *testing.T) {
bstree.Insert(4) bstree.Insert(4)
acturl := bstree.PostOrderTraverse() acturl := bstree.PostOrderTraverse()
assert.Equal([]int{5, 2, 4, 7, 6}, acturl) assert.Equal([]int{4, 2, 5, 7, 6}, acturl)
} }
func TestBSTree_InOrderTraverse(t *testing.T) { func TestBSTree_InOrderTraverse(t *testing.T) {
@@ -0,0 +1,50 @@
package datastructure_test
import (
"reflect"
"testing"
tree "github.com/duke-git/lancet/v2/datastructure/tree"
)
type postorderComparator struct{}
func (postorderComparator) Compare(a, b any) int {
x, y := a.(int), b.(int)
if x < y {
return -1
}
if x > y {
return 1
}
return 0
}
func TestBSTreePostOrderVisitsDescendantsBeforeParents(t *testing.T) {
for _, tc := range []struct {
name string
input, want []int
}{
{"balanced", []int{4, 2, 6, 1, 3, 5, 7}, []int{1, 3, 2, 5, 7, 6, 4}},
{"left chain", []int{5, 4, 3, 2}, []int{2, 3, 4, 5}},
{"right chain", []int{1, 2, 3, 4}, []int{4, 3, 2, 1}},
{"duplicate values", []int{5, 5, 5, 6}, []int{6, 5, 5, 5}},
{"single root", []int{7}, []int{7}},
} {
t.Run(tc.name, func(t *testing.T) {
tr := tree.NewBSTree(tc.input[0], postorderComparator{})
for _, v := range tc.input[1:] {
tr.Insert(v)
}
if got := tr.PostOrderTraverse(); !reflect.DeepEqual(got, tc.want) {
t.Fatalf("postorder=%v want %v", got, tc.want)
}
})
}
}
func TestBSTreePostOrderEmptyControl(t *testing.T) {
tr := tree.NewBSTree(7, postorderComparator{})
tr.Delete(7)
if got := tr.PostOrderTraverse(); len(got) != 0 {
t.Fatalf("empty traversal=%v", got)
}
}
+2 -2
View File
@@ -21,8 +21,8 @@ func preOrderTraverse[T any](node *datastructure.TreeNode[T]) []T {
func postOrderTraverse[T any](node *datastructure.TreeNode[T]) []T { func postOrderTraverse[T any](node *datastructure.TreeNode[T]) []T {
data := []T{} data := []T{}
if node != nil { if node != nil {
data = append(data, preOrderTraverse(node.Left)...) data = append(data, postOrderTraverse(node.Left)...)
data = append(data, preOrderTraverse(node.Right)...) data = append(data, postOrderTraverse(node.Right)...)
data = append(data, node.Value) data = append(data, node.Value)
} }
return data return data