From e2524f4498b2d8e9ea9c5e751d2ba1dd9c03b6fb Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Thu, 22 Oct 2026 05:56:27 +0300 Subject: [PATCH] fix(package): [queue] check membership only in active slots (#390) --- datastructure/queue/arrayqueue.go | 4 ++-- datastructure/queue/circularqueue.go | 4 ++-- datastructure/queue/contain_active_test.go | 25 ++++++++++++++++++++++ 3 files changed, 29 insertions(+), 4 deletions(-) create mode 100644 datastructure/queue/contain_active_test.go diff --git a/datastructure/queue/arrayqueue.go b/datastructure/queue/arrayqueue.go index 4532894..ef589f1 100644 --- a/datastructure/queue/arrayqueue.go +++ b/datastructure/queue/arrayqueue.go @@ -136,8 +136,8 @@ func (q *ArrayQueue[T]) Clear() { // Contain checks if the value is in queue or not func (q *ArrayQueue[T]) Contain(value T) bool { - for _, v := range q.data { - if reflect.DeepEqual(v, value) { + for i := q.head; i < q.tail; i++ { + if reflect.DeepEqual(q.data[i], value) { return true } } diff --git a/datastructure/queue/circularqueue.go b/datastructure/queue/circularqueue.go index 9700716..65e8834 100644 --- a/datastructure/queue/circularqueue.go +++ b/datastructure/queue/circularqueue.go @@ -108,8 +108,8 @@ func (q *CircularQueue[T]) Clear() { // Contain checks if the value is in queue or not func (q *CircularQueue[T]) Contain(value T) bool { - for _, v := range q.data { - if reflect.DeepEqual(v, value) { + for i := q.front; i != q.rear; i = (i + 1) % q.capacity { + if reflect.DeepEqual(q.data[i], value) { return true } } diff --git a/datastructure/queue/contain_active_test.go b/datastructure/queue/contain_active_test.go new file mode 100644 index 0000000..72309fe --- /dev/null +++ b/datastructure/queue/contain_active_test.go @@ -0,0 +1,25 @@ +package datastructure + +import "testing" + +func TestQueueContainActiveValues(t *testing.T) { + array := NewArrayQueue[int](5) + array.Enqueue(1) + array.Enqueue(2) + array.Dequeue() + if array.Contain(1) || !array.Contain(2) { + t.Error("array queue includes a dequeued value") + } + circular := NewCircularQueue[int](4) + if circular.Contain(0) { + t.Error("empty circular queue contains a zero value") + } + circular.Enqueue(1) + circular.Enqueue(2) + circular.Dequeue() + circular.Enqueue(3) + circular.Enqueue(4) + if circular.Contain(0) || circular.Contain(1) || !circular.Contain(4) { + t.Error("circular queue did not restrict its search to active values") + } +}