1
0
mirror of https://github.com/duke-git/lancet.git synced 2026-02-04 12:52:28 +08:00

refactor: fix bad code smell

This commit is contained in:
dudaodong
2022-11-29 23:50:17 +08:00
parent 29bdca1bd2
commit c39c8914fb

View File

@@ -4,15 +4,15 @@ package datastructure
type Set[T comparable] map[T]struct{} type Set[T comparable] map[T]struct{}
// NewSet return a instance of set // NewSet return a instance of set
func NewSet[T comparable](values ...T) Set[T] { func NewSet[T comparable](items ...T) Set[T] {
set := make(Set[T]) set := make(Set[T])
set.Add(values...) set.Add(items...)
return set return set
} }
// Add value to set // Add items to set
func (s Set[T]) Add(values ...T) { func (s Set[T]) Add(items ...T) {
for _, v := range values { for _, v := range items {
s[v] = struct{}{} s[v] = struct{}{}
} }
} }
@@ -54,9 +54,9 @@ func (s Set[T]) Clone() Set[T] {
return set return set
} }
// Delete value of set // Delete item of set
func (s Set[T]) Delete(values ...T) { func (s Set[T]) Delete(items ...T) {
for _, v := range values { for _, v := range items {
delete(s, v) delete(s, v)
} }
} }
@@ -89,13 +89,13 @@ func (s Set[T]) Size() int {
// Values return all values of set // Values return all values of set
func (s Set[T]) Values() []T { func (s Set[T]) Values() []T {
values := make([]T, 0, 0) result := make([]T, 0, len(s))
s.Iterate(func(value T) { s.Iterate(func(value T) {
values = append(values, value) result = append(result, value)
}) })
return values return result
} }
// Union creates a new set contain all element of set s and other // Union creates a new set contain all element of set s and other