mirror of
https://github.com/duke-git/lancet.git
synced 2026-11-16 05:12:11 +08:00
fix(fileutil): reject copies onto the source file (#379)
This commit is contained in:
1 parent
86dc6c0019
commit
778bd2e14f
2 files changed
+35
No files matched your search
@@ -229,6 +229,13 @@ func CopyFile(srcPath string, dstPath string) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
defer srcFile.Close()
|
defer srcFile.Close()
|
||||||
|
srcInfo, err := srcFile.Stat()
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if dstInfo, err := os.Stat(dstPath); err == nil && os.SameFile(srcInfo, dstInfo) {
|
||||||
|
return errors.New("source and destination are the same file")
|
||||||
|
}
|
||||||
|
|
||||||
distFile, err := os.Create(dstPath)
|
distFile, err := os.Create(dstPath)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|||||||
@@ -139,6 +139,34 @@ func TestCopyFile(t *testing.T) {
|
|||||||
os.Remove(destFile)
|
os.Remove(destFile)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestCopyFilePreservesSource(t *testing.T) {
|
||||||
|
for _, mode := range []string{"same", "hardlink", "different"} {
|
||||||
|
t.Run(mode, func(t *testing.T) {
|
||||||
|
assert := internal.NewAssert(t, "TestCopyFilePreservesSource")
|
||||||
|
src := filepath.Join(t.TempDir(), "source.txt")
|
||||||
|
assert.IsNil(os.WriteFile(src, []byte("keep this content"), 0600))
|
||||||
|
dst := src + ".copy"
|
||||||
|
if mode == "same" {
|
||||||
|
dst = src
|
||||||
|
} else if mode == "hardlink" {
|
||||||
|
if err := os.Link(src, dst); err != nil {
|
||||||
|
t.Skipf("hard links unavailable: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
err := CopyFile(src, dst)
|
||||||
|
if (err != nil) != (mode != "different") {
|
||||||
|
t.Errorf("unexpected copy result: %v", err)
|
||||||
|
}
|
||||||
|
data, err := os.ReadFile(src)
|
||||||
|
assert.IsNil(err)
|
||||||
|
assert.Equal("keep this content", string(data))
|
||||||
|
data, err = os.ReadFile(dst)
|
||||||
|
assert.IsNil(err)
|
||||||
|
assert.Equal("keep this content", string(data))
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestReadFileToString(t *testing.T) {
|
func TestReadFileToString(t *testing.T) {
|
||||||
assert := internal.NewAssert(t, "TestReadFileToString")
|
assert := internal.NewAssert(t, "TestReadFileToString")
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user