From 752f1ed63d01a28ecfaf25349b513bf78c64b5ce Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Thu, 22 Oct 2026 05:48:53 +0300 Subject: [PATCH] fix(package): [datetime] count calendar days across DST (#385) --- datetime/datetime.go | 6 +----- datetime/dayofyear_dst_test.go | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 datetime/dayofyear_dst_test.go diff --git a/datetime/datetime.go b/datetime/datetime.go index 51916ec..a0332e6 100644 --- a/datetime/datetime.go +++ b/datetime/datetime.go @@ -343,11 +343,7 @@ func BetweenSeconds(t1 time.Time, t2 time.Time) int64 { // DayOfYear returns which day of the year the parameter date `t` is. // Play: https://go.dev/play/p/0hjqhTwFNlH func DayOfYear(t time.Time) int { - y, m, d := t.Date() - firstDay := time.Date(y, 1, 1, 0, 0, 0, 0, t.Location()) - nowDate := time.Date(y, m, d, 0, 0, 0, 0, t.Location()) - - return int(nowDate.Sub(firstDay).Hours() / 24) + return t.YearDay() - 1 } // IsWeekend checks if passed time is weekend or not. diff --git a/datetime/dayofyear_dst_test.go b/datetime/dayofyear_dst_test.go new file mode 100644 index 0000000..a9afed5 --- /dev/null +++ b/datetime/dayofyear_dst_test.go @@ -0,0 +1,20 @@ +package datetime + +import ( + "testing" + "time" + _ "time/tzdata" +) + +func TestDayOfYearDaylightSaving(t *testing.T) { + loc, err := time.LoadLocation("America/New_York") + if err != nil { + t.Fatal(err) + } + for _, month := range []time.Month{time.January, time.July, time.December} { + date := time.Date(2024, month, 1, 12, 0, 0, 0, loc) + if got, want := DayOfYear(date), date.YearDay()-1; got != want { + t.Errorf("%v: got %d, want %d", date, got, want) + } + } +}