From 5c04ffae973cac49a40869d428e98a7234958be1 Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Thu, 22 Oct 2026 05:48:16 +0300 Subject: [PATCH] fix(package): [datetime] reject non-positive intervals (#386) --- datetime/datetime.go | 3 +++ datetime/interval_test.go | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 datetime/interval_test.go diff --git a/datetime/datetime.go b/datetime/datetime.go index b4b687a..51916ec 100644 --- a/datetime/datetime.go +++ b/datetime/datetime.go @@ -495,6 +495,9 @@ func GenerateDatetimesBetween(start, end time.Time, layout string, interval stri if err != nil { return nil, err } + if duration <= 0 { + return nil, fmt.Errorf("interval must be positive") + } for current := start; !current.After(end); current = current.Add(duration) { result = append(result, current.Format(layout)) diff --git a/datetime/interval_test.go b/datetime/interval_test.go new file mode 100644 index 0000000..0a8b5a2 --- /dev/null +++ b/datetime/interval_test.go @@ -0,0 +1,17 @@ +package datetime + +import ( + "testing" + "time" +) + +func TestGenerateDatetimesNonPositiveInterval(t *testing.T) { + start := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC) + for _, interval := range []string{"0s", "-1h"} { + t.Run(interval, func(t *testing.T) { + if _, err := GenerateDatetimesBetween(start, start.Add(time.Hour), "2006-01-02", interval); err == nil { + t.Error("expected an error for a non-positive interval") + } + }) + } +}