From 3b94ec1932a48a544622ae5dd37831ad4f6ec4d4 Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Thu, 22 Oct 2026 05:28:40 +0300 Subject: [PATCH] fix(package): [netutil] bracket IPv6 dial addresses (#398) --- netutil/net.go | 2 +- netutil/telnet_ipv6_test.go | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 netutil/telnet_ipv6_test.go diff --git a/netutil/net.go b/netutil/net.go index a3b4c51..baf9d3b 100644 --- a/netutil/net.go +++ b/netutil/net.go @@ -315,7 +315,7 @@ func IsPingConnected(host string) bool { // IsTelnetConnected checks if can telnet specified host or not. // Play: https://go.dev/play/p/yiLCGtQv_ZG func IsTelnetConnected(host string, port string) bool { - adder := host + ":" + port + adder := net.JoinHostPort(host, port) conn, err := net.DialTimeout("tcp", adder, 5*time.Second) if err != nil { diff --git a/netutil/telnet_ipv6_test.go b/netutil/telnet_ipv6_test.go new file mode 100644 index 0000000..7f50713 --- /dev/null +++ b/netutil/telnet_ipv6_test.go @@ -0,0 +1,21 @@ +package netutil + +import ( + "net" + "testing" +) + +func TestIsTelnetConnectedIPv6(t *testing.T) { + listener, err := net.Listen("tcp6", "[::1]:0") + if err != nil { + t.Skipf("IPv6 loopback unavailable: %v", err) + } + defer listener.Close() + host, port, err := net.SplitHostPort(listener.Addr().String()) + if err != nil { + t.Fatal(err) + } + if !IsTelnetConnected(host, port) { + t.Error("could not connect to the IPv6 loopback listener") + } +}