From 34c7e36d29503ce02ff5997953eeb14e445c92bb Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Fri, 23 Oct 2026 13:14:06 +0300 Subject: [PATCH] fix(slice): pass actual comparison indexes to DifferenceBy (#370) --- slice/slice.go | 4 ++-- slice/slice_test.go | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/slice/slice.go b/slice/slice.go index f5ff0e6..3983ad0 100644 --- a/slice/slice.go +++ b/slice/slice.go @@ -187,8 +187,8 @@ func DifferenceBy[T comparable](slice []T, comparedSlice []T, iteratee func(inde result := make([]T, 0) comparedMap := make(map[T]struct{}, len(comparedSlice)) - for _, item := range comparedSlice { - comparedMap[iteratee(0, item)] = struct{}{} + for i, item := range comparedSlice { + comparedMap[iteratee(i, item)] = struct{}{} } for i, item := range slice { diff --git a/slice/slice_test.go b/slice/slice_test.go index ef6db9c..45a97f0 100644 --- a/slice/slice_test.go +++ b/slice/slice_test.go @@ -1205,6 +1205,9 @@ func TestDifferenceBy(t *testing.T) { } assert.Equal([]int{1, 2}, DifferenceBy(s1, s2, addOne)) + assert.Equal([]int{}, DifferenceBy([]int{10, 10}, []int{10, 10}, func(i, v int) int { + return i + v + })) } func TestIsAscending(t *testing.T) {