From 33a7e5bf6d45acb1ecf1a44d95cc2fbbe7ac7f0a Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Fri, 23 Oct 2026 13:14:41 +0300 Subject: [PATCH] fix(strutil): validate Hamming distance by rune count (#368) --- strutil/string.go | 7 +++---- strutil/string_test.go | 3 +++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/strutil/string.go b/strutil/string.go index d6dcf61..630f01e 100644 --- a/strutil/string.go +++ b/strutil/string.go @@ -632,12 +632,11 @@ func SubInBetween(str string, start string, end string) string { // This func returns an error if the input strings are of unequal lengths. // Play: https://go.dev/play/p/glNdQEA9HUi func HammingDistance(a, b string) (int, error) { - if len(a) != len(b) { - return -1, errors.New("a length and b length are unequal") - } - ar := []rune(a) br := []rune(b) + if len(ar) != len(br) { + return -1, errors.New("a length and b length are unequal") + } var distance int for i, codepoint := range ar { diff --git a/strutil/string_test.go b/strutil/string_test.go index 75592c1..bb48a11 100644 --- a/strutil/string_test.go +++ b/strutil/string_test.go @@ -818,6 +818,9 @@ func TestHammingDistance(t *testing.T) { {"abc", "def", 3}, {"kitten", "sitting", -1}, {"ö", "ü", 1}, + {"abc", "你", -1}, + {"你", "abc", -1}, + {"a", "你", 1}, {"日本語", "日本語", 0}, {"日本語", "語日本", 3}, }