From 0f4f73fbba08518cce17ba57ebb9c19642586db5 Mon Sep 17 00:00:00 2001 From: Yusuf Efe <120668197+yuefdev@users.noreply.github.com> Date: Fri, 23 Oct 2026 13:19:46 +0300 Subject: [PATCH] fix(mathutil): divide before multiplying LCM factors (#363) --- mathutil/mathutil.go | 2 +- mathutil/mathutil_test.go | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/mathutil/mathutil.go b/mathutil/mathutil.go index 9966263..035fa6e 100644 --- a/mathutil/mathutil.go +++ b/mathutil/mathutil.go @@ -368,7 +368,7 @@ func lcm[T constraints.Integer](a, b T) T { if a == 0 || b == 0 { panic("lcm function: provide non zero integers only.") } - return a * b / gcd(a, b) + return a / gcd(a, b) * b } // Cos returns the cosine of the radian argument. diff --git a/mathutil/mathutil_test.go b/mathutil/mathutil_test.go index 1bbc993..c304306 100644 --- a/mathutil/mathutil_test.go +++ b/mathutil/mathutil_test.go @@ -17,6 +17,13 @@ func TestExponent(t *testing.T) { assert.Equal(int64(100), Exponent(10, 2)) } +func TestLCMIntermediateOverflow(t *testing.T) { + assert := internal.NewAssert(t, "TestLCMIntermediateOverflow") + assert.Equal(uint8(32), LCM(uint8(32))) + assert.Equal(uint8(192), LCM(uint8(64), uint8(96))) + assert.Equal(uint64(1<<40), LCM(uint64(1<<40), uint64(1<<39))) +} + func TestFibonacci(t *testing.T) { t.Parallel()