feat: add IsInt, IsFloat, IsNumber

formatter/formatter.go

@@ -5,11 +5,6 @@
 package formatter
 
 import (
-	"fmt"
-	"reflect"
-	"strconv"
-	"strings"
-
 	"golang.org/x/exp/constraints"
 )
 
@@ -18,54 +13,57 @@ import (
 // Comma("12345", "$") => "$12,345", Comma(12345, "$") => "$12,345"
 // Play: https://go.dev/play/p/eRD5k2vzUVX
 func Comma[T constraints.Float | constraints.Integer | string](value T, symbol string) string {
-	s, err := numberToString(value)
-	if err != nil {
-		return ""
-	}
+	// s, err := numberToString(value)
+	// if err != nil {
+	// 	return ""
+	// }
 
-	dotIndex := strings.Index(s, ".")
-	if dotIndex != -1 {
-		return symbol + commaString(s[:dotIndex]) + s[dotIndex:]
-	}
+	// dotIndex := strings.Index(s, ".")
+	// if dotIndex != -1 {
+	// 	return symbol + commaString(s[:dotIndex]) + s[dotIndex:]
+	// }
+
+	// return symbol + commaString(s)
+
+	return ""
 
-	return symbol + commaString(s)
 }
 
-func commaString(s string) string {
-	if len(s) <= 3 {
-		return s
-	}
-	return commaString(s[:len(s)-3]) + "," + commaString(s[len(s)-3:])
-}
+// func commaString(s string) string {
+// 	if len(s) <= 3 {
+// 		return s
+// 	}
+// 	return commaString(s[:len(s)-3]) + "," + commaString(s[len(s)-3:])
+// }
 
-func numberToString(value any) (string, error) {
-	switch reflect.TypeOf(value).Kind() {
-	case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64,
-		reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
-		return fmt.Sprintf("%v", value), nil
+// func numberToString(value any) (string, error) {
+// 	switch reflect.TypeOf(value).Kind() {
+// 	case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64,
+// 		reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
+// 		return fmt.Sprintf("%v", value), nil
 
-		// todo: need to handle 12345678.9 => 1.23456789e+07
-	case reflect.Float32, reflect.Float64:
-		return fmt.Sprintf("%v", value), nil
+// 		// todo: need to handle 12345678.9 => 1.23456789e+07
+// 	case reflect.Float32, reflect.Float64:
+// 		return fmt.Sprintf("%v", value), nil
 
-	case reflect.String:
-		{
-			sv := fmt.Sprintf("%v", value)
-			if strings.Contains(sv, ".") {
-				_, err := strconv.ParseFloat(sv, 64)
-				if err != nil {
-					return "", err
-				}
-				return sv, nil
-			} else {
-				_, err := strconv.ParseInt(sv, 10, 64)
-				if err != nil {
-					return "", nil
-				}
-				return sv, nil
-			}
-		}
-	default:
-		return "", nil
-	}
-}
+// 	case reflect.String:
+// 		{
+// 			sv := fmt.Sprintf("%v", value)
+// 			if strings.Contains(sv, ".") {
+// 				_, err := strconv.ParseFloat(sv, 64)
+// 				if err != nil {
+// 					return "", err
+// 				}
+// 				return sv, nil
+// 			} else {
+// 				_, err := strconv.ParseInt(sv, 10, 64)
+// 				if err != nil {
+// 					return "", nil
+// 				}
+// 				return sv, nil
+// 			}
+// 		}
+// 	default:
+// 		return "", nil
+// 	}
+// }

formatter/formatter_test.go

@@ -16,6 +16,7 @@ func TestComma(t *testing.T) {
 	assert.Equal("12,345", Comma("12345", ""))
 	assert.Equal("12,345.6789", Comma("12345.6789", ""))
 	assert.Equal("123,456,789,000", Comma("123456789000", ""))
+	assert.Equal("12,345,678.9", Comma("12345678.9", ""))
 
 	assert.Equal("12,345", Comma(12345, ""))
 	assert.Equal("$12,345", Comma(12345, "$"))